[FFmpeg-soc] DCA encoder

[Bartlomiej Wolowiec]

Sunday 22 March 2009 19:13:13 Michael Niedermayer napisał(a):
> On Sun, Mar 22, 2009 at 04:18:26PM +0100, Bartlomiej Wolowiec wrote:
> > Hi,
> > I had some free time recently, so I had written some code for FFmpeg :)
> > I improved significantly DCA encoder. It works for any SUB(SUB)FRAMES and
> > any sample rate. Also files are played correctly with libdts. I will try
> > to make LFE and some extensions works soon.
>
> just a quick check from my evil patcheck
>
> Non static with no ff_/av_ prefix
> /dcaenc.diff:212:+void put_frame(DCAContext *c, int32_t
> subband_data[PCM_SAMPLES][MAX_CHANNELS][32], uint8_t *frame)
>
>  Non doxy comments
> /dcaenc.diff:32:+    int32_t
> subband[PCM_SAMPLES][MAX_CHANNELS][DCA_SUBBANDS_32]; /*
> [sample][channel][subband] */ /dcaenc.diff-33- } DCAContext;
> /dcaenc.diff-34-
> --
> /dcaenc.diff-71-+    /* From dca.c */
> /dcaenc.diff:72:+    static const int bitlen[11] = { 0, 1, 2, 2, 2, 2, 3,
> 3, 3, 3, 3 }; /dcaenc.diff:73:+    static const int thr[11] = { 0, 1, 3, 3,
> 3, 3, 7, 7, 7, 7, 7 };
>
> Missing changelog entry (ignore if minor change)
>
> [...]

Hmm... I've just noticed your patcheck. Generally dcaenc.c isn't good, but I 
will try to correct it :)

-- 
Bartlomiej Wolowiec