[FFmpeg-soc] DCA encoder

[Michael Niedermayer]

On Sun, Mar 22, 2009 at 04:18:26PM +0100, Bartlomiej Wolowiec wrote:
> Hi,
> I had some free time recently, so I had written some code for FFmpeg :)
> I improved significantly DCA encoder. It works for any SUB(SUB)FRAMES and any 
> sample rate. Also files are played correctly with libdts. I will try to make 
> LFE and some extensions works soon.

just a quick check from my evil patcheck

Non static with no ff_/av_ prefix
/dcaenc.diff:212:+void put_frame(DCAContext *c, int32_t subband_data[PCM_SAMPLES][MAX_CHANNELS][32], uint8_t *frame)

 Non doxy comments
/dcaenc.diff:32:+    int32_t subband[PCM_SAMPLES][MAX_CHANNELS][DCA_SUBBANDS_32]; /* [sample][channel][subband] */
/dcaenc.diff-33- } DCAContext;
/dcaenc.diff-34- 
--
/dcaenc.diff-71-+    /* From dca.c */
/dcaenc.diff:72:+    static const int bitlen[11] = { 0, 1, 2, 2, 2, 2, 3, 3, 3, 3, 3 };
/dcaenc.diff:73:+    static const int thr[11] = { 0, 1, 3, 3, 3, 3, 7, 7, 7, 7, 7 };

Missing changelog entry (ignore if minor change)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20090322/98d49699/attachment.pgp>