[FFmpeg-soc] [RFC] Possible jpeg2k decoder rewrite

[Jai Menon]

On Mon, Jun 15, 2009 at 11:02 AM, Kostya<kostya.shishkov at gmail.com> wrote:
> On Mon, Jun 15, 2009 at 09:54:09AM +0530, Jai Menon wrote:
>> On Sun, Jun 14, 2009 at 11:51 PM, Kostya<kostya.shishkov at gmail.com> wrote:
>> > On Sun, Jun 14, 2009 at 04:51:36PM +0000, Jai Menon wrote:
>> >> On Wed, Jun 10, 2009 at 11:45 AM, Michael Niedermayer<michaelni at gmx.at> wrote:
>> >> > On Tue, Jun 09, 2009 at 03:25:52PM +0000, Jai Menon wrote:
>> >> >> On Sat, May 2, 2009 at 8:23 PM, Michael Niedermayer<michaelni at gmx.at> wrote:
>> >> >> > On Sun, May 03, 2009 at 12:56:02AM +0530, Jai Menon wrote:
>> >> >> >> On 4/26/09, Michael Niedermayer <michaelni at gmx.at> wrote:
>> >> >> >> > On Sun, Apr 26, 2009 at 05:47:11PM +0530, Jai Menon wrote:
>> >> >> >> >  > On 4/26/09, Michael Niedermayer <michaelni at gmx.at> wrote:
>> >> >> >> >  > > On Sun, Apr 26, 2009 at 04:17:48PM +0530, Jai Menon wrote:
>> >>
>> >> [...]
>> >>
>> >> >> I think I have narrowed the problem down to the tagtree decoding code,
>> >> >> but don't know what to fix and where to fix.
>> >> >
>> >> > in the most generic sense you should have some difference between some
>> >> > reference implementation and our decoder
>> >> > whereever that is there is prior code that can be tested for being
>> >> > different or not.
>> >> >
>> >> > if you tell us what variable with what value in what line of our code differs
>> >> > from what in what line of some reference we might be able to help ...
>> >>
>> >> I tried rewriting that part from scratch based on the spec, and still
>> >> get the same problems. So maybe my assumption was wrong.
>> >>
>> >> The file i'm using is file
>> >> http://samples.mplayerhq.hu/jpeg2000/j2kp4files_v1_2.zip/testfiles_jp2/file3.jp2
>> >
>> > Ahem, that's ZIP archive and some files inside it are compressed.
>>
>> You mean the dir testfiles_jp2 isn't there inside that archive?
>
> Ah, found it.
> Can you also debug block state (lblock, lengthinc, newpasses) before and
> after those tree decoding calls?

Okay, here goes here is the diff -up output for attached logs :

 length increment 786
 Size of packet 10 is 10259
 Packet no 11
-Inclusion bit set
-New passes 16
-block increment 3
-length increment 656
-Inclusion bit set
-New passes 16
-block increment 3
-length increment 686
-Inclusion bit set

So inclusion bit read(from the tagtree) is incorrect for packet 11.
Complete output attached if you want to perform any other regex-fu.


-- 
Regards,

Jai
-------------- next part --------------
Packet no 1
Inclusion bit set
New passes 19
block increment 2
length increment 274
Size of packet 1 is 278
Packet no 2
Inclusion bit set
New passes 13
block increment 0
length increment 55
Size of packet 2 is 58
Packet no 3
Inclusion bit set
New passes 16
block increment 0
length increment 58
Size of packet 3 is 61
Packet no 4
Inclusion bit set
New passes 19
block increment 1
length increment 252
Inclusion bit set
New passes 19
block increment 2
length increment 258
Inclusion bit set
New passes 22
block increment 2
length increment 265
Size of packet 4 is 785
Packet no 5
Inclusion bit set
New passes 13
block increment 0
length increment 44
Inclusion bit set
New passes 13
block increment 0
length increment 58
Inclusion bit set
New passes 16
block increment 0
length increment 50
Size of packet 5 is 162
Packet no 6
Inclusion bit set
New passes 13
block increment 0
length increment 46
Inclusion bit set
New passes 13
block increment 0
length increment 57
Inclusion bit set
New passes 13
block increment 0
length increment 47
Size of packet 6 is 160
Packet no 7
Inclusion bit set
New passes 22
block increment 3
length increment 949
Inclusion bit set
New passes 22
block increment 3
length increment 955
Inclusion bit set
New passes 22
block increment 3
length increment 968
Size of packet 7 is 2883
Packet no 8
Inclusion bit set
New passes 13
block increment 2
length increment 172
Inclusion bit set
New passes 16
block increment 1
length increment 192
Inclusion bit set
New passes 16
block increment 1
length increment 192
Size of packet 8 is 567
Packet no 9
Inclusion bit set
New passes 16
block increment 1
length increment 164
Inclusion bit set
New passes 16
block increment 1
length increment 179
Inclusion bit set
New passes 13
block increment 2
length increment 179
Size of packet 9 is 533
Packet no 10
Inclusion bit set
New passes 22
block increment 5
length increment 2595
Inclusion bit set
New passes 22
block increment 3
length increment 830
Inclusion bit set
New passes 22
block increment 5
length increment 2703
Inclusion bit set
New passes 22
block increment 3
length increment 702
Inclusion bit set
New passes 22
block increment 5
length increment 2620
Inclusion bit set
New passes 22
block increment 3
length increment 786
Size of packet 10 is 10259
Packet no 11
Size of packet 11 is 1
Packet no 12
Inclusion bit set
New passes 1
block increment 1
length increment 14
Inclusion bit set
New passes 1
block increment 0
length increment 4
Size of packet 12 is 21
Packet no 13
Size of packet 13 is 1
Packet no 14
Inclusion bit set
New passes 3
block increment 1
length increment 21
Inclusion bit set
New passes 1
block increment 0
length increment 5
Size of packet 14 is 31
Packet no 15
Size of packet 15 is 1
Packet no 16
Inclusion bit set
New passes 5
block increment 2
length increment 62
Inclusion bit set
New passes 1
block increment 3
length increment 44
Inclusion bit set
New passes 1
block increment 3
length increment 50
Size of packet 16 is 164
Packet no 17
Inclusion bit set
New passes 3
block increment 1
length increment 11
Inclusion bit set
New passes 1
block increment 1
length increment 14
Inclusion bit set
New passes 1
block increment 0
length increment 2
Size of packet 17 is 35
Packet no 18
Inclusion bit set
New passes 1
block increment 1
length increment 10
Inclusion bit set
New passes 2
block increment 2
length increment 6
Inclusion bit set
New passes 5
block increment 0
length increment 9
Inclusion bit set
New passes 1
block increment 0
length increment 7
Size of packet 18 is 42
-------------- next part --------------
Packet no 1
Inclusion bit set
New passes 19
block increment 2
length increment 274
Size of packet 1 is 278
Packet no 2
Inclusion bit set
New passes 13
block increment 0
length increment 55
Size of packet 2 is 58
Packet no 3
Inclusion bit set
New passes 16
block increment 0
length increment 58
Size of packet 3 is 61
Packet no 4
Inclusion bit set
New passes 19
block increment 1
length increment 252
Inclusion bit set
New passes 19
block increment 2
length increment 258
Inclusion bit set
New passes 22
block increment 2
length increment 265
Size of packet 4 is 785
Packet no 5
Inclusion bit set
New passes 13
block increment 0
length increment 44
Inclusion bit set
New passes 13
block increment 0
length increment 58
Inclusion bit set
New passes 16
block increment 0
length increment 50
Size of packet 5 is 162
Packet no 6
Inclusion bit set
New passes 13
block increment 0
length increment 46
Inclusion bit set
New passes 13
block increment 0
length increment 57
Inclusion bit set
New passes 13
block increment 0
length increment 47
Size of packet 6 is 160
Packet no 7
Inclusion bit set
New passes 22
block increment 3
length increment 949
Inclusion bit set
New passes 22
block increment 3
length increment 955
Inclusion bit set
New passes 22
block increment 3
length increment 968
Size of packet 7 is 2883
Packet no 8
Inclusion bit set
New passes 13
block increment 2
length increment 172
Inclusion bit set
New passes 16
block increment 1
length increment 192
Inclusion bit set
New passes 16
block increment 1
length increment 192
Size of packet 8 is 567
Packet no 9
Inclusion bit set
New passes 16
block increment 1
length increment 164
Inclusion bit set
New passes 16
block increment 1
length increment 179
Inclusion bit set
New passes 13
block increment 2
length increment 179
Size of packet 9 is 533
Packet no 10
Inclusion bit set
New passes 22
block increment 5
length increment 2595
Inclusion bit set
New passes 22
block increment 3
length increment 830
Inclusion bit set
New passes 22
block increment 5
length increment 2703
Inclusion bit set
New passes 22
block increment 3
length increment 702
Inclusion bit set
New passes 22
block increment 5
length increment 2620
Inclusion bit set
New passes 22
block increment 3
length increment 786
Size of packet 10 is 10259
Packet no 11
Inclusion bit set
New passes 16
block increment 3
length increment 656
Inclusion bit set
New passes 16
block increment 3
length increment 686
Inclusion bit set
New passes 19
block increment 3
length increment 702
Size of packet 11 is 2056
Packet no 12
Inclusion bit set
New passes 16
block increment 3
length increment 592
Inclusion bit set
New passes 16
block increment 3
length increment 644
Inclusion bit set
New passes 19
block increment 3
length increment 657
Size of packet 12 is 1905
Packet no 13
Inclusion bit set
New passes 19
block increment 4
length increment 1989
Inclusion bit set
New passes 19
block increment 4
length increment 2004
Inclusion bit set
New passes 22
block increment 5
length increment 2644
Inclusion bit set
New passes 22
block increment 5
length increment 2480
Inclusion bit set
New passes 22
block increment 4
length increment 1556
Inclusion bit set
New passes 22
block increment 4
length increment 1413
Inclusion bit set
New passes 19
block increment 5
length increment 2113
Inclusion bit set
New passes 19
block increment 4
length increment 2027
Inclusion bit set
New passes 19
block increment 5
length increment 2746
Inclusion bit set
New passes 22
block increment 5
length increment 2427
Inclusion bit set
New passes 22
block increment 4
length increment 1460
Inclusion bit set
New passes 19
block increment 4
length increment 1041
Inclusion bit set
New passes 16
block increment 4
length increment 2013
Inclusion bit set
New passes 19
block increment 4
length increment 2006
Inclusion bit set
New passes 22
block increment 5
length increment 2712
Inclusion bit set
New passes 19
block increment 5
length increment 2433
Inclusion bit set
New passes 19
block increment 4
length increment 1596
Inclusion bit set
New passes 16
block increment 4
length increment 1279
Size of packet 13 is 36007
Packet no 14
Inclusion bit set
New passes 16
block increment 4
length increment 1921
Inclusion bit set
New passes 16
block increment 3
length increment 602
Inclusion bit set
New passes 19
block increment 4
length increment 2007
Inclusion bit set
New passes 13
block increment 4
length increment 547
Inclusion bit set
New passes 16
block increment 5
length increment 2118
Inclusion bit set
New passes 16
block increment 3
length increment 618
Size of packet 14 is 7836
Packet no 15
Inclusion bit set
New passes 19
block increment 4
length increment 1836
Inclusion bit set
New passes 13
block increment 3
length increment 501
Inclusion bit set
New passes 16
block increment 4
length increment 1944
Inclusion bit set
New passes 13
block increment 3
length increment 495
Inclusion bit set
New passes 16
block increment 5
length increment 2071
Inclusion bit set
New passes 16
block increment 3
length increment 551
Size of packet 15 is 7421
Packet no 16
Inclusion bit set
New passes 13
block increment 5
length increment 1508
Inclusion bit set
New passes 16
block increment 4
length increment 1590
Inclusion bit set
New passes 16
block increment 4
length increment 1445
Inclusion bit set
New passes 16
block increment 4
length increment 1111
Inclusion bit set
New passes 13
block increment 5
length increment 1205
Inclusion bit set
New passes 16
block increment 4
length increment 1967
Inclusion bit set
New passes 19
block increment 5
length increment 2609
Inclusion bit set
New passes 16
block increment 4
length increment 1286
Inclusion bit set
New passes 16
block increment 4
length increment 1612
Inclusion bit set
New passes 19
block increment 4
length increment 2002
Inclusion bit set
New passes 19
block increment 5
length increment 2504
Inclusion bit set
New passes 16
block increment 4
length increment 1415
Inclusion bit set
New passes 19
block increment 4
length increment 2027
Inclusion bit set
New passes 19
block increment 5
length increment 2593
Inclusion bit set
New passes 19
block increment 5
length increment 2416
Inclusion bit set
New passes 19
block increment 4
length increment 1765
Inclusion bit set
New passes 16
block increment 5
length increment 2474
Inclusion bit set
New passes 19
block increment 5
length increment 2785
Inclusion bit set
New passes 19
block increment 5
length increment 2810
Inclusion bit set
New passes 19
block increment 5
length increment 2137
Inclusion bit set
New passes 13
block increment 5
length increment 1538
Inclusion bit set
New passes 13
block increment 5
length increment 1551
Inclusion bit set
New passes 16
block increment 4
length increment 1500
Inclusion bit set
New passes 13
block increment 5
length increment 1042
Inclusion bit set
New passes 16
block increment 4
length increment 1341
Inclusion bit set
New passes 19
block increment 4
length increment 1923
Inclusion bit set
New passes 16
block increment 5
length increment 2374
Inclusion bit set
New passes 16
block increment 4
length increment 1555
Inclusion bit set
New passes 16
block increment 4
length increment 1952
Inclusion bit set
New passes 19
block increment 4
length increment 1853
Inclusion bit set
New passes 19
block increment 5
length increment 2320
Inclusion bit set
New passes 16
block increment 4
length increment 1601
Inclusion bit set
New passes 19
block increment 5
length increment 2303
Inclusion bit set
New passes 19
block increment 5
length increment 2417
Inclusion bit set
New passes 19
block increment 5
length increment 2255
Inclusion bit set
New passes 16
block increment 4
length increment 1816
Inclusion bit set
New passes 16
block increment 5
length increment 2291
Inclusion bit set
New passes 19
block increment 5
length increment 2335
Inclusion bit set
New passes 16
block increment 5
length increment 2115
Inclusion bit set
New passes 13
block increment 5
length increment 1510
Inclusion bit set
New passes 10
block increment 5
length increment 1339
Inclusion bit set
New passes 13
block increment 5
length increment 1401
Inclusion bit set
New passes 13
block increment 5
length increment 1335
Inclusion bit set
New passes 10
block increment 4
length increment 972
Inclusion bit set
New passes 13
block increment 5
length increment 1137
Inclusion bit set
New passes 13
block increment 5
length increment 1652
Inclusion bit set
New passes 16
block increment 5
length increment 2166
Inclusion bit set
New passes 13
block increment 5
length increment 1200
Inclusion bit set
New passes 16
block increment 4
length increment 1562
Inclusion bit set
New passes 13
block increment 5
length increment 1669
Inclusion bit set
New passes 16
block increment 5
length increment 2121
Inclusion bit set
New passes 13
block increment 5
length increment 1318
Inclusion bit set
New passes 16
block increment 4
length increment 2022
Inclusion bit set
New passes 16
block increment 5
length increment 2178
Inclusion bit set
New passes 16
block increment 4
length increment 2031
Inclusion bit set
New passes 13
block increment 5
length increment 1584
Inclusion bit set
New passes 16
block increment 5
length increment 2363
Inclusion bit set
New passes 16
block increment 5
length increment 2290
Inclusion bit set
New passes 16
block increment 5
length increment 2122
Inclusion bit set
New passes 13
block increment 5
length increment 1600
Size of packet 16 is 111139
Packet no 17
Inclusion bit set
New passes 16
block increment 4
length increment 1700
Inclusion bit set
New passes 13
block increment 5
length increment 1662
Inclusion bit set
New passes 16
block increment 5
length increment 2231
Inclusion bit set
New passes 19
block increment 4
length increment 2022
Inclusion bit set
New passes 16
block increment 4
length increment 1187
Inclusion bit set
New passes 16
block increment 4
length increment 1085
Inclusion bit set
New passes 13
block increment 5
length increment 1759
Inclusion bit set
New passes 13
block increment 5
length increment 1689
Inclusion bit set
New passes 16
block increment 5
length increment 2318
Inclusion bit set
New passes 16
block increment 4
length increment 1983
Inclusion bit set
New passes 13
block increment 5
length increment 1179
Inclusion bit set
New passes 13
block increment 4
length increment 979
Inclusion bit set
New passes 16
block increment 4
length increment 1944
Inclusion bit set
New passes 13
block increment 5
length increment 1827
Inclusion bit set
New passes 16
block increment 5
length increment 2438
Inclusion bit set
New passes 16
block increment 5
length increment 2157
Inclusion bit set
New passes 16
block increment 4
length increment 1277
Inclusion bit set
New passes 13
block increment 5
length increment 1107
Size of packet 17 is 30613
Packet no 18
Inclusion bit set
New passes 13
block increment 5
length increment 1692
Inclusion bit set
New passes 13
block increment 5
length increment 1672
Inclusion bit set
New passes 19
block increment 5
length increment 2107
Inclusion bit set
New passes 16
block increment 4
length increment 1905
Inclusion bit set
New passes 13
block increment 5
length increment 1027
Inclusion bit set
New passes 13
block increment 4
length increment 996
Inclusion bit set
New passes 16
block increment 4
length increment 1781
Inclusion bit set
New passes 16
block increment 4
length increment 1694
Inclusion bit set
New passes 16
block increment 5
length increment 2154
Inclusion bit set
New passes 13
block increment 5
length increment 1842
Inclusion bit set
New passes 13
block increment 5
length increment 1080
Inclusion bit set
New passes 13
block increment 4
length increment 926
Inclusion bit set
New passes 13
block increment 5
length increment 1944
Inclusion bit set
New passes 16
block increment 4
length increment 1855
Inclusion bit set
New passes 16
block increment 5
length increment 2303
Inclusion bit set
New passes 16
block increment 4
length increment 2019
Inclusion bit set
New passes 13
block increment 5
length increment 1194
Inclusion bit set
New passes 13
block increment 5
length increment 1039
Size of packet 18 is 29299