[FFmpeg-soc] [soc]: r4440 - in concat/libavformat: m3u.c playlist.c playlist.h

[Baptiste Coudurier]

On 6/12/2009 6:54 PM, Geza Kovacs wrote:
> On 06/12/2009 06:21 PM, Baptiste Coudurier wrote:
>> Hi,
>>
>> On 6/12/2009 5:53 PM, gkovacs wrote:
>>> Author: gkovacs
>>> Date: Sat Jun 13 02:53:22 2009
>>> New Revision: 4440
>>>
>>> Log:
>>> removed unnecessary code, should work with same-codec different-format combinations as-is, requires an (in-progress) patch to ffmpeg.c and ffplay.c to handle changing streams during decoding
>>>
>> Please avoid suck huge commits which are just impossible to review.
>> Split changes, keeping them related, and do small but frequent commits.
>>
>> Quick review:
>>
>>> [...]
>>>
>>> +char* buf_getline(ByteIOContext *s)
>> This should be static.
>>
> 
> I will be using that function, as well as all the others declared in
> playlist.h, in the PLS playlist demuxer as well, which is in a separate
> file. Isn't declaring it as static going to restrict it to a single
> playlist demuxer?
> 

In this case functions should be in a common file, and must use a ff_
prefix.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org