[FFmpeg-soc] [soc]: r4390 - in afilters: Makefile.dummy af_null.c avfilter.c avfilter.h dummy.c

[Stefano Sabatini]

On date Monday 2009-06-08 22:17:51 +0200, Vitor Sessak encoded:
> kdub wrote:
[...]
>>  /**
>>   * Adds a new reference to a picture.
>>   * @param ref   an existing reference to the picture
>> @@ -345,6 +359,17 @@ struct AVFilterPad
>>       * and another value on error.
>>       */
>>      int (*config_props)(AVFilterLink *link);
>> +
>> +
>> +    /**
>> +     * Process an audio buffer. This function is where the audio filter should

ProcessES, third person is preferred, also please don't forget the
final dot in sentences.

>> +     * recieve and process data
>
> recEIve
>
>> +     */
>> +    int (*start_buffer)(AVFilterLink *link);
>> +
>> +    int (*end_buffer)(AVFilterLink *link);
>> +
>> +
>>  };
>
> @Michael: If you are going to complain of having start_buffer() for  
> audio and start_frame() for video, this it the best time for it.

We're still in time to change:
start_frame -> start_video_frame
start_buffer -> start_audio_buffer

or maybe apply some better solution (I'm just wondering then how are
we going to name the Subtitle/Text functions...).

Regards.