[FFmpeg-soc] [soc]: r4382 - in rtmp: TODO checkout.sh rtmp.h rtmp.patch rtmpdec.c rtmppkt.c rtmppkt.h rtmpproto.c

[Ronald S. Bultje]

Hi,

On Thu, Jun 4, 2009 at 9:45 AM, Diego Biurrun <diego at biurrun.de> wrote:
> On Thu, Jun 04, 2009 at 01:19:27PM +0300, Kostya wrote:
>> On Thu, Jun 04, 2009 at 11:56:34AM +0200, Diego Biurrun wrote:
>> > On Thu, Jun 04, 2009 at 08:57:37AM +0200, kostya wrote:
>> > > +++ rtmp/rtmpproto.c      Thu Jun  4 08:57:37 2009        (r4382)
>> > > @@ -0,0 +1,117 @@
>> > > +
>> > > +/**
>> > > + * url syntax: rtp://host:port[?option=val...]
>> > > + * option: 'ttl=n'       : set the ttl value (for multicast only)
>> > > + *         'localport=n' : set the local port to n
>> > > + *
>> > > + */
>> > > +
>> > > +static int rtmp_open(URLContext *h, const char *uri, int flags)
>> >
>> > nit: stray empty line
>>
>> copypasted from libavformat/rtpproto.c, all doxy comments there have an
>> additional empty line
>
> Do you intend to keep the c+p code?

My question also: why copy the code? My impression was always that
this part should be shareable, maybe with a hack^d^d^dbeautiful
insertion of additional code here and there.

Ronald