[FFmpeg-soc] [soc]: r4838 - in concat/libavformat: concat.c concatgen.h m3u.c pls.c xspf.c

[Diego Biurrun]

On Wed, Jul 29, 2009 at 11:04:39AM -0700, Geza Kovacs wrote:
> >> +#ifndef AVFORMAT_CONCATGEN_H
> >> +#define AVFORMAT_CONCATGEN_H
> >> +
> >> +#include "playlist.h"
> >> +
> >> +int ff_concatgen_read_packet(AVFormatContext *s, AVPacket *pkt);
> >> +
> >> +int ff_concatgen_read_seek(AVFormatContext *s, int stream_index, int64_t pts, int flags);
> > 
> > Does this pass 'make checkheaders' or 'make libavformat/concatgen.ho'?
> > It looks as though it needs avformat.h and stdint.h.
> 
> It passed make libavformat/concatgen.h; avformat.h is included via
> playlist,h, while stdint.h is included via avio.h

You should #include headers directly instead of relying on some other
header to #include them indirectly.  The latter procedure is very
brittle.

Diego