[FFmpeg-soc] [soc]: r4583 - wmapro/wma3dec.c

[Aurelien Jacobs]

On Sat, Jul 04, 2009 at 10:44:33AM +0200, faust3 wrote:
> Author: faust3
> Date: Sat Jul  4 10:44:32 2009
> New Revision: 4583
> 
> Log:
> align vertical
> 
> Modified:
>    wmapro/wma3dec.c
> 
> Modified: wmapro/wma3dec.c
> ==============================================================================
> --- wmapro/wma3dec.c	Sat Jul  4 10:39:12 2009	(r4582)
> +++ wmapro/wma3dec.c	Sat Jul  4 10:44:32 2009	(r4583)
> @@ -860,7 +860,7 @@ static int decode_coeffs(WMA3DecodeConte
>               vals[0] = (symbol_to_vec4[idx] >> 8) >> 4;
>               vals[1] = (symbol_to_vec4[idx] >> 8) & 0xF;
>               vals[2] = (symbol_to_vec4[idx] >> 4) & 0xF;
> -             vals[3] = symbol_to_vec4[idx] & 0xF;
> +             vals[3] =  symbol_to_vec4[idx] & 0xF;
>          }

Those 4 lines could be better aligned. Maybe something like:

             vals[0] = (symbol_to_vec4[idx] >> 12)      ;
             vals[1] = (symbol_to_vec4[idx] >>  8) & 0xF;
             vals[2] = (symbol_to_vec4[idx] >>  4) & 0xF;
             vals[3] = (symbol_to_vec4[idx]      ) & 0xF;

Oh, and if this code is not speed critical, it could obvioulsy
be written as a loop, but I'm not sure if it's a good idea.

Aurel