[FFmpeg-soc] [soc]: r3937 - dvbmuxer/mpegtsenc.c

[Baptiste Coudurier]

Tomer Barletz wrote:
>> [...]
>>
>> @@ -81,6 +106,7 @@ static void mpegts_write_section(MpegTSS
>>
>>         buf_ptr += len1;
>>         len -= len1;
>> +        ts->cur_pcr += TS_PACKET_SIZE*8*90000LL/ts->mux_rate;
> 
> Why 8?
> 

Because ts->mux_rate is in bits/s not bytes.


>> [...]
>>
>> @@ -580,7 +582,7 @@ static void mpegts_write_pes(AVFormatCon
>>         payload += len;
>>         payload_size -= len;
>>         put_buffer(s->pb, buf, TS_PACKET_SIZE);
>> -        ts->cur_pcr += (TS_PACKET_SIZE+write_pcr)*8*90000LL / ts->mux_rate;
>> +        ts->cur_pcr += TS_PACKET_SIZE*8*90000LL/ts->mux_rate;
> 
> And again...

See above.

> 
> It seems like you assume each SI section duration is 8 packets long.
> Am I correct?

Nope.

> Anyway, this does not seem too accurate to me. Have we abandoned the
> former method of calculating each written SI packet?

This method is correct, I think.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no