[FFmpeg-soc] [soc]: r4028 - in wmapro: wma3.h wma3dec.c

Sascha Sommer saschasommer at freenet.de
Sun Feb 8 22:03:54 CET 2009


Hi,

On Sonntag, 8. Februar 2009, Diego Biurrun wrote:
> On Sun, Feb 08, 2009 at 09:21:26PM +0100, faust3 wrote:
> > Log:
> > consistently use num as abbreviation for number of
>
> good idea
>
> > --- wmapro/wma3dec.c	Sun Feb  8 20:50:31 2009	(r4027)
> > +++ wmapro/wma3dec.c	Sun Feb  8 21:21:25 2009	(r4028)
> > @@ -52,7 +52,7 @@ static void dump_context(WMA3DecodeConte
> >      PRINT("len prefix",s->len_prefix);
> > -    PRINT("nb channels",s->nb_channels);
> > +    PRINT("nb channels",s->num_channels);
>
> Why did you leave the nb in place?
>

Thanks for spotting this. There were even more places where I forgot to do the 
renames.

> > @@ -112,7 +112,7 @@ static av_cold int wma3_decode_end(AVCod
> >
> >      if(s->def_decorrelation_mat){
> > -        for(i=1;i<=s->nb_channels;i++)
> > +        for(i=1;i<=s->num_channels;i++)
>
> These would be more readable with some spaces...
>

I'll try to fix this once I iterate over wma3dec.c

Regards

Sascha





More information about the FFmpeg-soc mailing list