[FFmpeg-soc] [soc]: r5043 - wmapro/wmaprodec.c

[Diego Biurrun]

On Wed, Aug 12, 2009 at 09:50:28PM +0200, Sascha Sommer wrote:
> 
> On Mittwoch, 12. August 2009, Benoit Fouet wrote:
> >
> > faust3 wrote :
> > > --- wmapro/wmaprodec.c	Wed Aug 12 20:51:19 2009	(r5042)
> > > +++ wmapro/wmaprodec.c	Wed Aug 12 20:55:40 2009	(r5043)
> > > @@ -276,12 +276,10 @@ static av_cold int decode_init(AVCodecCo
> > > -#ifdef DEBUG
> > >          /** dump the extradata */
> > >          for (i=0 ; i<avctx->extradata_size ; i++)
> > > -            av_log(avctx, AV_LOG_DEBUG, "[%x] ",avctx->extradata[i]);
> > > -        av_log(avctx, AV_LOG_DEBUG, "\n");
> > > -#endif
> > > +            dprintf(avctx, "[%x] ",avctx->extradata[i]);
> > > +        dprintf(avctx, "\n");
> >
> > instead of generating no code at all, this will be a loop of nop, is it
> > really what you want ?
> 
> It should not really matter as it is called only once during init.
> Besides that this code will now also work when dprintf no longer depends on 
> DEBUG.

How would dprintf not depend on DEBUG?

Diego