[FFmpeg-soc] [RFC] How to pass frames to buffer source filter (was: r3760 - in libavfilter: Makefile allfilters.c diffs/02_ffmpeg_filters.diff vsrc_buffer.c vsrc_buffer.h)

[Aurelien Jacobs]

Vitor Sessak wrote:

> Aurelien Jacobs escreveu:
> > vitor wrote:
> > 
> >> Author: vitor
> >> Date: Wed Oct  8 20:11:13 2008
> >> New Revision: 3760
> >>
> >> Log:
> >> Create a buffer source filter instead of duplicating it in ffmpeg.c and 
> >> ffplay.c
> >>
> >> [...]
> >>
> >>  Index: ffmpeg.c
> >>  ===================================================================
> >> ---- ffmpeg.c	(revision 15000)
> >> +--- ffmpeg.c	(revision 15585)
> >>  +++ ffmpeg.c	(working copy)
> >> -@@ -41,6 +41,12 @@
> >> +@@ -41,6 +41,13 @@
> >>   #include "libavutil/avstring.h"
> >>   #include "libavformat/os_support.h"
> >>   
> >> @@ -10,12 +10,13 @@ Index: ffmpeg.c
> >>  +# include "libavfilter/avfilter.h"
> >>  +# include "libavfilter/avfiltergraph.h"
> >>  +# include "libavfilter/graphparser.h"
> >> ++# include "libavfilter/vsrc_buffer.h"
> > 
> > As long as this header is not public, ffmpeg shouldn't rely on it.
> 
> This is related to your comment below...

Not entirely.
It would be best to not include this header at all, but if it's really
needed and that you find no better way, then this header must be part
of public API, and must be added to the list of installed headers in
the Makefile.

Aurel