[FFmpeg-soc] [soc]: r2262 - alacenc/alacenc.c

[Michael Niedermayer]

On Fri, May 30, 2008 at 12:49:47PM +0200, Benjamin Larsson wrote:
[...]
> > +/**
> > + * put_sbits
> > + * @param pb PutBitContext pointer
> > + * @param bits Number of bits to be output
> > + * @param val Data Bits
> > + */
> > +static void put_sbits(PutBitContext *pb, int bits, int32_t val)
> > +{
> > +    put_bits(pb, bits, val & ((1<<bits)-1));
> > +}
> 
> This should be moved to bitstream.h me thinks.

no
from the current use 
put_bits(a,b,(uint16_t)c)

is enough and cleaner. of course that might change and a different
solution might become better as more or different code is added which
uses similar put_bits() constructs ...
Its too early to say how this should be done, and definitly to early to
move it into bitstream.h

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20080530/315249dc/attachment.pgp>