[FFmpeg-soc] expand filter (alternative to pad syntax)

[Michael Niedermayer]

On Sat, May 17, 2008 at 10:36:38PM +0900, Ryo Hirafuji wrote:
> Hi.
> I simplified the source.
> "sscanf" works very well, thanks. ^^
> 
> I have some questions.
> 
> > there is always a way :)
> > Code duplication is not acceptable in ffmpeg and always means patch rejection
> > so if there is no way to access the information from pix_fmt_info then
> > solution would be to add a way ...
> 
> So... you mean that I should post ffmpeg-dev with a patch of libavcodec?

Yes, unless there is already a way to access the needed information.


> 
> >> > as with vmrsss, unconditional copying is not ok
> >> Other filters are also drawing images in the same way, aren't they?
> >> (For example,vf_drawbox.)
> >
> > there is no memcpy() in vf_drawbox
> 
> Yes, but "vf_drawbox" also draws images into the memory directly.
> (please see "draw_box()")

Yes, and expand could draw the black border in the memory directly.
If the allocated buffer would be large enough.
The tricky part is to make it large enough.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20080518/34e22c1a/attachment.pgp>