[FFmpeg-soc] [soc]: r2021 - in?eac3:?ac3dec.h?ac3dec_data.c?ac3dec_data.h eac3dec.c

[Bartlomiej Wolowiec]

On czwartek, 27 marca 2008, Michael Niedermayer wrote:
> > >  You do this in stream_type but this name is totally wrong this is not
> > > a stream_type. It is not even constant for a stream. NEVER even think
> > > of using a name from the a52* spec, the people who wrote it are idiots.
> > > Its a flag indicating the start/end of a frame. And IMHO it should be
> > > returned more directly than as a context variable but thats rather
> > > minor the name is a major issue. It totally confused me until looked it
> > > up in the spec.
[...]
> > 2.change of stream_type to frame_type

According to your suggestion, I changed name of stream type  to frame type. 
Should correction of type of frame_type from uint8_t to EAC3FrameType be in 
separate patch?

-- 
Bartlomiej Wolowiec
-------------- next part --------------
A non-text attachment was scrubbed...
Name: step2.patch
Type: text/x-diff
Size: 3338 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20080328/9c26a016/attachment.patch>