[FFmpeg-soc] [soc]: r2021?-?in?eac3:?ac3dec.h?ac3dec_data.c?ac3dec_data.h eac3dec.c

[Michael Niedermayer]

On Fri, Mar 28, 2008 at 08:11:32PM +0100, Bartlomiej Wolowiec wrote:
> On piątek, 28 marca 2008, Michael Niedermayer wrote:
> > There are 3 types in EAC3
> > Type 0: always start a frame and may or may not have further parts
> > following Type 1: never start a frame and may or may not have further parts
> > following Type 2: always start a frame and never have further parts
> > following
> >
> > That is
> >
> > |T0 | T0 T1 | T0 T1 T1 ... T1 | T2 |
> >
> > are all and the only valid combinations accoriding to my spec
> >
> > I cannot map this to your code at all
> >
> > [...]
> 
> You're right I forgot about frames EAC3_STREAM_TYPE_AC3_CONVERT type, which 
> should be given FRAME_COMPLETE flag
> 
> -- 
> Bartlomiej Wolowiec

[...]

> +typedef enum{
> +    /** finishes portions of data */
> +    FRAME_COMPLETE,
> +    /** starts portions of data
> +     * (if there are any frames in the buffer they're send) */
> +    FRAME_START,
> +    /** continues portions of data (adds them to buffer) */
> +    FRAME_CONTINUATION
> +}AACAC3FrameFlag;

Please use:
Complete frame, ends previous frame
Frame start, ends previous frame
Part of the previous frame

And patch ok


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20080328/a721e0c0/attachment.pgp>