[FFmpeg-soc] [soc]: r2021 - in eac3: ac3dec.h ac3dec_data.c ac3dec_data.h eac3dec.c

Michael Niedermayer michaelni at gmx.at
Sat Mar 22 00:41:13 CET 2008


On Sat, Mar 22, 2008 at 12:19:37AM +0100, Bartlomiej Wolowiec wrote:
> while removing redundant parts of the code I've removed quite important 
> part... I enclose fixed version

This contains several unrelated changes.

First the the addition of AACAC3HeaderInfo, IMHO you should simply pass a
pointer to AACAC3ParseContext into sync(). This should be in a seperate patch
and can likely hit ffmpeg svn quickly.

Then there is the change which adds a bap_tab parameter this is useless
as its always ff_ac3_bap_tab.

Then theres the export of num_blocks, that as well belongs into a seperate
patch and ill like to hear 1 sentance why it is needed. But i guess this as
well can hit svn quickly

The rest ill review when above is seperated out.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20080322/4ded7afc/attachment.pgp>


More information about the FFmpeg-soc mailing list