[FFmpeg-soc] [soc]: r1951 - in libavfilter: Makefile allfilters.c vf_drawbox.c

Vitor Sessak vitor1001 at gmail.com
Sat Mar 8 23:58:59 CET 2008


Hi and thanks for testing

Víctor Paesa wrote:
> Hi,
> 
> On Sat, Mar 1, 2008 at 12:04 PM, vitor <subversion at mplayerhq.hu> wrote:
> [...]
>>  Added:
>>    libavfilter/vf_drawbox.c
> 
> [...]
> 
>>  +static void strlwr(char *str)
>>  +{
>>  +    int i = 0;
>>  +    while(str[i] != '\0') {
>>  +        if(isupper(str[i]))
>>  +            str[i] = tolower(str[i]);
>>  +
>>  +        i++;
>>  +    }
>>  +}
> 
> On Cygwin this strlwr() conflicts with another one defined in string.h
> I imagine other systems may also use this popular function name,
> any problem to add a "ff_" prefix?

I'd prefer a "box_" prefix, since it is a static function used only in 
vf_drawbox.c...

-Vitor



More information about the FFmpeg-soc mailing list