[FFmpeg-soc] [soc]: r1965 - aac/aac.c

Andreas Öman andreas at olebyn.nu
Wed Mar 5 14:01:27 CET 2008


Aurelien Jacobs wrote:
> andoma wrote:
> 
>> Author: andoma
>> Date: Wed Mar  5 13:42:28 2008
>> New Revision: 1965
>>
>> Log:
>> Move LTP_ROUND() close to where it's used. 
>>
>> Part of LTP conditional compilation.
>>
>>
>> [...]
>>  
>> +
>> +/**
>> + * @todo: Replace this with float_to_int16()
>> + */
>> +static inline int16_t LTP_ROUND(float x) {
> 
> Not related to this commit, but all uppercase function names
> are ugly.

Agree

> 
>> +    if (x >= 0)
> 
> I don't really see the point of this test.

Neither do I, but as the comment suggest the function
should go away the day I (or someone else) fixes
LTP support. I just moved it for now to avoid even more ifdef-hell.




More information about the FFmpeg-soc mailing list