[FFmpeg-soc] [soc]: r2491 - aac/aac.c

Aurelien Jacobs aurel at gnuage.org
Fri Jun 20 19:03:33 CEST 2008


superdump wrote:

> Author: superdump
> Date: Fri Jun 20 14:28:28 2008
> New Revision: 2491
> 
> Log:
> Some vertical alignment
> 
> 
> Modified:
>    aac/aac.c
> 
> Modified: aac/aac.c
> ==============================================================================
> --- aac/aac.c	(original)
> +++ aac/aac.c	Fri Jun 20 14:28:28 2008
> @@ -69,7 +69,7 @@ DECLARE_ALIGNED_16(static float, sine_sh
>   * Audio Object Types
>   */
>  enum {
> -    AOT_NULL = 0x0,
> +    AOT_NULL             = 0x0,
                             ^^^^^
Strange to have this value in hex while others are decimal...
(I'm not even mentioning the fact that this =0 is useless,
because I guess it may help readability)

>      AOT_AAC_MAIN,
>      AOT_AAC_LC,
>      AOT_AAC_SSR,
> @@ -79,13 +79,13 @@ enum {
>      AOT_TWINVQ,
>      AOT_CELP,
>      AOT_HVXC,
> -    AOT_TTSI = 12,
> +    AOT_TTSI             = 12,
>      AOT_MAINSYNTH,
>      AOT_WAVESYNTH,
>      AOT_MIDI,
>      AOT_SAFX,
>      AOT_ER_AAC_LC,
> -    AOT_ER_AAC_LTP = 19,
> +    AOT_ER_AAC_LTP       = 19,
>      AOT_ER_AAC_SCALABLE,
>      AOT_ER_TWINVQ,
>      AOT_ER_BSAC,


Oh, and some other remarks about other enums:

enum {
    ID_SCE = 0x0,
    ID_CPE,
    ID_CCE,
    ID_LFE,
    ID_DSE,
    ID_PCE,
    ID_FIL,
    ID_END
};

Here (and in some other enum), the =0 is clearly useless.
And the last line of the enum could be ended with a ',' like
any other line, to potentially simplify future patches.

Aurel



More information about the FFmpeg-soc mailing list