[FFmpeg-soc] [PATCH] 4/4 Split sws_getContext_altivec_alloc_context from sws_getContext

Luca Barbato lu_zero at gentoo.org
Wed Jun 11 08:30:45 CEST 2008


Michael Niedermayer wrote:
> On Wed, Jun 11, 2008 at 02:36:08AM +0200, Keiji Costantini wrote:
>> -                p[j] = c->vLumFilter[i];
>> -                p[j] = c->vChrFilter[i];
> 
> Whichever way this is done and whereever, it should be done at the
> same place where lum/chrMmxFilter is initialized.
> And of course both altivec & mmx should use the same array for the same data.
> 
> But looking again it seems these arrays are practically unused and the
> code using it looks like it shouldnt use them in the first place.
> 
> So, correct cleanup seems to be to remove vCCoeffsBank and vYCoeffsBank.

The *Banks are just a copy from aligned memory to another, so just using 
the vLumFilter and vChrFilter directly won't cause problems.

lu

-- 

Luca Barbato
Gentoo Council Member
Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero




More information about the FFmpeg-soc mailing list