[FFmpeg-soc] [soc]: r2396 - aacenc/aacenc.c

[Robert Swain]

2008/6/7 Diego Biurrun <diego at biurrun.de>:
> On Sat, Jun 07, 2008 at 02:01:47PM +0300, Kostya wrote:
>> On Sat, Jun 07, 2008 at 11:56:14AM +0200, Diego Biurrun wrote:
>> > On Sat, Jun 07, 2008 at 11:48:02AM +0200, kostya wrote:
>> > >
>> > > Log:
>> > > Rename context variable for consistency
>> > >
>> > > --- aacenc/aacenc.c       (original)
>> > > +++ aacenc/aacenc.c       Sat Jun  7 11:48:02 2008
>> > > @@ -62,14 +62,14 @@ static int put_audio_specific_config(AVC
>> > >  static int aac_encode_init(AVCodecContext *avctx)
>> > >  {
>> > > -    AACEncContext *c = avctx->priv_data;
>> > > +    AACEncContext *s = avctx->priv_data;
>> >
>> > Is 's' really a better name for a context than 'c'?
>>
>> Have I said anything about it being a better name?
>> I'm equally used to "c" and "s" for codec context names.
>> But the majority of names here was "s", so I decided to
>> stick to it.
>
> FTLIW, I prefer 'c' or 'ctx', but use whatever floats your boat.

WDEIOURATACU? IVA!!!

(Why does everyone insist on using random acronyms that aren't common
usage? It's very annoying!)

Though I guess you meant "For the little it's worth" or something
along those lines. If I'm finding it awkward to read the acronyms as
an English-speaking country native I dread to think of the nightmares
other people are having trying to read all this acronym-ised crap.
Just my two pence.

And I think ctx makes more sense but I'm not too bothered as it's
usually obvious that the single letter variable is AVCodecContext or
the individual codec context.

Rob