[FFmpeg-soc] [soc]: r2831 - mxf/mxfenc.c

[zhentan feng]

Hi

2008/7/20 Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:

> On Sun, Jul 20, 2008 at 03:24:09PM +0200, spyfeng wrote:
> > Author: spyfeng
> > Date: Sun Jul 20 15:24:08 2008
> > New Revision: 2831
> >
> > Log:
> > fix bugs for putting correct param into function put_buffer()
> >
> >
> > Modified:
> >    mxf/mxfenc.c
> >
> > Modified: mxf/mxfenc.c
> >
> ==============================================================================
> > --- mxf/mxfenc.c      (original)
> > +++ mxf/mxfenc.c      Sun Jul 20 15:24:08 2008
> > @@ -352,7 +352,7 @@ static int mxf_write_preface(AVFormatCon
> >
> >      // write create date as unknown
> >      mxf_write_local_tag(pb, 8, 0x3B02);
> > -    put_buffer(pb, 0, 8);
> > +    put_buffer(pb, "0", 8);
>
> Uh, that is still just as wrong as before. What exactly are you trying
> to do??
> Actually, it probably is worse, because it can still segfault (the
> source buffer you pass is only two bytes long), but in addition the
> values are wrong, there is one byte that is '0' and one that is '\0'
> and then there is some random stuff, whatever constant the compiler
> placed after this.
> Did you maybe mean
> > put_be64(pb, 0);
>

 aha, yes, you are right.
 I just want to put all 8 bytes long as zero.
Thanks.

-- 
Best wishes~