[FFmpeg-soc] libavfilter: movie source filter

[Víctor Paesa]

Hi,

On Jan 27, 2008 8:18 PM, Vitor Sessak <vitor1001 at gmail.com> wrote:
> Hi, and sorry for taking so long to look at it.

No problem, SoC doesn't have FFmpeg's frenetic pace.

> Víctor Paesa wrote:
> > Hi,
> >
> > On Jan 27, 2008 3:42 PM, Diego Biurrun <diego at biurrun.de> wrote:
> >> On Sun, Jan 27, 2008 at 03:31:48PM +0100, Víctor Paesa wrote:
> >>> Here is attached the next revision:
>
> [...]
>
> > +    return 0;
> > +}
> > +
> > +static int config_props(AVFilterLink *link)
> > +{
> > +    MovieContext *mv = link->src->priv;
> > +
> > +    link->w = mv->w;
> > +    link->h = mv->h;
> > +
>
> I think you should set the aspect ratio. Something like
>
> link->dst->outputs[0]->outpic->pixel_aspect.num =
> mv->pCodecCtx->sample_aspect_ratio.num;
> link->dst->outputs[0]->outpic->pixel_aspect.den =
> mv->pCodecCtx->sample_aspect_ratio.den;

Thanks for your review, and the code snippet. I have set it in
a different place, I hope is correct.

Attached is revision fourth, should there be no further comments
I will commit it tomorrow.

Regards,
Víctor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.libavfilter.movie.4.diff
Type: text/x-patch
Size: 13834 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20080128/e7492ad0/attachment.bin>