[FFmpeg-soc] Libavfilter reviewing...

[Vitor Sessak]

Hi

Víctor Paesa wrote:
> Hi,
> 
> On Feb 9, 2008 9:09 PM, Vitor Sessak wrote:
>> Michael Niedermayer wrote:
>>> On Sat, Feb 09, 2008 at 06:04:32PM +0100, Vitor Sessak wrote:
>>>> Hi all,
>>>>
>>>> I think that libavfilter should be soon be in a shape good enough to
>>>> svn. What would be the preferred method of getting it reviewed? Should I
>>>> post several patches to the -devel ML? I think an interesting order to
>>>> get things commited is
>>>>
>>>> 1-First pack (in one big chunk):
>>>>
>>>> avfilter.{c,h} (but with the initialization of the filters removed, to
>>>> compile with no filters)
>>>> allfilters.h (mostly empty, no filters yet)
>>>> defaults.c
>>>> vf_scale.c
>>>> formats.c
>>>> 00_build.diff (with --disable-avfilter as default)
>>>>
>>>> 2-Second pack (one file at a time):
>>>>
>>>> avfiltergraph.{c,h} (without the graphfile support)
>>>> 04_ffmpeg_filters.diff (with cropping and padding disabled)
>>>> vf_crop.c
>>>>
>>>> 3-All the rest
>>>>
>>>> 4-Enabling it by default.
>>>>
>>>> Michael, Bobby, Víctor, any opinions?
>>> Yes, post the first patch soon!
>>> And id move the enabling up in the list if possible. Actually id enable
>>> as much as possible as soon as possible.
>> Well Bobby, Víctor, since Michael looks motivated in reviewing it, I
>> gave it a try. Please shout if you see anything you don't agree with...
> 
> A point missing is documentation. There are some usage hints in README,
> and some others in filter's code that might be moved into hooks.texi
> This file might eventually need a new name.

Don't forget also 
http://wiki.multimedia.cx/index.php?title=FFmpeg_filter_howto .

> All this fits well under the "3-All the rest" in the plan ;-)

:-)

-Vitor