[FFmpeg-soc] MXF muxer version 0.0.4

zhentan feng spyfeng at gmail.com
Sat Aug 30 04:25:43 CEST 2008


Hi

2008/8/30 Baptiste Coudurier <baptiste.coudurier at smartjog.com>

> [...]
> >
> > ------------------------------------------------------------------------
> >
> > Index: libavformat/mxfenc.c
> > ===================================================================
> > --- libavformat/mxfenc.c      (revision 15018)
> > +++ libavformat/mxfenc.c      (working copy)
> > @@ -32,7 +32,10 @@
> >  //#define DEBUG
> >
> >  #include "mxf.h"
> > +#include <wchar.h>
> >
> > +typedef wchar_t MXFUTF16String;
> > +
>
> You don't need that, you need to transform char * to utf-16.
>
> [...]
>
> > [...]
> >
> > @@ -331,14 +344,16 @@
> >
> >      mxf_write_metadata_key(pb, 0x013000);
> >      PRINT_KEY(s, "identification key", pb->buf_ptr - 16);
> > -    company_name_len = sizeof("FFmpeg");
> > -    product_name_len = sizeof("OP1a Muxer");
> > +    company_name_len = (wcslen(L"FFmpeg") + 1) * 2;
> > +    product_name_len = (wcslen(L"OP1a Muxer") + 1) * 2;
> >
> >      length = 80 + company_name_len + product_name_len;
> > -    if (!(s->streams[0]->codec->flags & CODEC_FLAG_BITEXACT)) {
> > -        version_string_len = sizeof(LIBAVFORMAT_IDENT);
> > -        length += 4 + version_string_len;
> > -    }
> > +    if (!(s->streams[0]->codec->flags & CODEC_FLAG_BITEXACT))
> > +        version_string_len = (wcslen(WCS_LIBAVFORMAT_IDENT) + 1) * 2;
> > +    else
> > +        version_string_len = (wcslen(L"0.0.0") + 1) * 2;
> > +
> > +    length += 4 + version_string_len;
> >      klv_encode_ber_length(pb, length);
>
> Something like:
> If (bitexact) version_string = LIBAVFORMAT_VERSION
> else          version_string = "0.0.0"
>
> This is version btw, not ident.
>
>
here is new patch version 0.0.10.
thanks.
-- 
Best wishes~
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mxf_mux_0.0.10.patch
Type: text/x-diff
Size: 2240 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20080830/f7294a33/attachment.patch>


More information about the FFmpeg-soc mailing list