[FFmpeg-soc] [soc]: r3561 - mlp/mlpenc.c

[Michael Niedermayer]

On Sat, Aug 23, 2008 at 12:44:30PM -0300, Ramiro Polla wrote:
> ramiro wrote:
> > Author: ramiro
> > Date: Sat Aug 23 17:39:25 2008
> > New Revision: 3561
> > 
> > Log:
> > Simple stereo decorrelation (mostly copied from alacenc.c).
> 
> This is 1.4% worse than the previous fixed L, L-R decorrelation. There 
> is some overhead because of changing coeffs, but it shouldn't be this 
> bad. Any ideas why? (maybe estimate_stereo_mode() isn't that precise?)

your code is likely buggy
the first most obvious part is that you randomly commented a part out
under #if 0, of course this doesnt mean that the rest is working
its not hard to add a av_log/printf() and verify with pencil and paper if
it does apply the expected L-R,R; ... to a sample ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20080823/dc4f7ec9/attachment.pgp>