[FFmpeg-soc] [Patch] Maxis EA XA decoder - GSoC Task

[compn]

Michael Niedermayer <michaelni at ...> writes:

> 
> On Fri, Apr 11, 2008 at 03:41:48PM +0200, Robert Marston wrote:
> > >  > > > +                    sample = ((((*(src+channel) >> i) & 0x0F) << 
0x1C) >> shift[channel]);
> > >  > >
> > >  > >  This looks buggy.
> > >  >
> > >  > Where do you think the error would occur?
> > >
> > >  on some non x86 hardware
> > 
> > What exactly you referring to here? The shift operators? A problem
> > with the Endianess maybe?
> 
> Its related to the shifts.


i dont mean to be rude, but i believe that Robert may need some more verbose 
output from you :)

> > >  > >  Still wrong
> > >  > Corrected?
> > >  no
> > Am I right in saying the pts should be incremented by 28 *
> no


more verbosity needed here too.

-compn