[FFmpeg-soc] [Patch] Maxis EA XA decoder - GSoC Task

Robert Marston rmarston at gmail.com
Thu Apr 10 12:02:59 CEST 2008


On Wed, Apr 9, 2008 at 7:50 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Wed, Apr 09, 2008 at 04:28:50PM +0200, Robert Marston wrote:
> > >
>  > >  > +    else {
>  > >
>  > > > +        pkt->stream_index = xa->audio_stream_index;
>  > >  > +        pkt->pts = 90000;
>  > >  > +        pkt->pts *= xa->audio_frame_counter;
>  > >  > +        pkt->pts /= xa->sampleRate;
>  > >  > +        xa->audio_frame_counter += (14 * xa->channels);  /* 14 Samples per channel  */
>  > >
>  > >  to quote the documentation
>  > >  "int64_t pts;                            ///< presentation time stamp in time_base units"
>  > >
>  > >  This is not what you set it to
>  > >
>  > Removed this as I am unsure of the time base.
>
>  So i assume you are sure that its unneeded to set pts here? If so please
>  explain why it is unneeded. If not please set pts to a correct value.
>
>
I am unsure what the pts value should be set to here .Other demuxers
seem to set it to what I had originally in the above code and I am not
entirely sure what you mean by time_base units?

Thanks for your help
Robert



More information about the FFmpeg-soc mailing list