[FFmpeg-soc] [Patch] Maxis EA XA decoder - GSoC Task

[Diego Biurrun]

On Tue, Apr 08, 2008 at 04:43:25PM +0200, Robert Marston wrote:
> 
> Also I attached a unified diff created with the GNU diff. If this is not
> correct I am not sure what other diff program to use.

The diff you attached is perfectly acceptable, but a straight 'svn diff'
is likely easier for you to produce.

The build system part of your patch is OK.

> --- /home/rob/ffmpeg/libavformat/xa.c	1970-01-01 02:00:00.000000000 +0200
> +++ ffmpeg/libavformat/xa.c	2008-04-08 14:37:44.000000000 +0200
> @@ -0,0 +1,131 @@
> +/*
> + * Maxis XA (.xa) File Demuxer

file demuxer

> +/**
> + * @file xa.c
> + * Maxis XA Audio Demuxer

audio demuxer

Umm, wait, is this a file or an audio demuxer?

> +static int xa_probe(AVProbeData *p)
> +{ 

trailing whitespace

> +    packet_size = 15*xa->channels;/* 1 byte header and 14 bytes worth of samples * number channels per block */

Is it just me who dislikes long comments to the right of lines instead
of above?

Diego