[FFmpeg-soc] [soc]:?r2021?-?in?eac3:?ac3dec.h?ac3dec_data.c?ac3dec_data.h?eac3dec ??.c

[Michael Niedermayer]

On Wed, Apr 09, 2008 at 10:16:50AM +0200, Bartlomiej Wolowiec wrote:
> On piątek, 4 kwietnia 2008, Michael Niedermayer wrote:
> > a third one (and i think its the best one) is
> > just to read the header with the channel num before the returning it after
> > ff_combine_frame(). It has to be a complete frame at that point, also
> > please reuse the code from the decoder for this if possible!
> 
> Ok, according to your suggestion, I will read the number of channels when 
> there is complete frame. Is it a good idea to make a small extension of 
> ac3_parser and add to it an argument which shows if channel_map should be 
> read and then add ac3_parser call at the end of aac_ac3_parser...?

id just add a parse_header() call to aac_ac3_parser() which is always
executed when a frame is finished. So that parse_header() would be like
sync().

The code below "/* allow downmixing to stereo (or mono for AC3) */"could
also be moved into this parse_header()

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20080409/987c087e/attachment.pgp>