[FFmpeg-soc] [soc]: r1393 - in dirac/libavcodec: dirac.h diracdec.c diracenc.c

[Marco Gerards]

Diego Biurrun <diego at biurrun.de> writes:

> On Fri, Sep 21, 2007 at 11:11:09PM +0200, Marco Gerards wrote:
>> marco <subversion at mplayerhq.hu> writes:
>> 
>> > Log:
>> > copy files to prepare splitting up dirac.c
>> >
>> > Added:
>> >    dirac/libavcodec/dirac.h
>> >       - copied unchanged from r1392, /dirac/libavcodec/dirac.c
>> >    dirac/libavcodec/diracdec.c
>> >       - copied unchanged from r1392, /dirac/libavcodec/dirac.c
>> >    dirac/libavcodec/diracenc.c
>> >       - copied unchanged from r1392, /dirac/libavcodec/dirac.c
>> 
>> It seems one commit email in which I make the changes to these files
>> is missing, or I am crazy (not very unlikely).
>
> I just resent that mail to myself, it is 394k big and thus likely held
> by the mailing list software.

Oh, right...

> In any case, this was not the way to go.  r1393 is pointless, creating
> identical copies of files makes no sense.  Instead, create the new files
> with 'svn copy', make your modifications, then commit the changed files.
> You can do this separately for encoder and decoder to limit the size of
> the commit.

Sorry for that, I thought this was the way to go.  Now I know this for
next time...

Although my main concerns are with if I made the split correctly as in
code wise.

Thanks,
Marco