[FFmpeg-soc] [soc]: r1341 - in eac3: eac3.h eac3dec.c

Diego Biurrun diego at biurrun.de
Wed Sep 12 11:45:10 CEST 2007


On Wed, Sep 12, 2007 at 09:53:51AM +0200, bwolowiec wrote:
> 
> --- eac3/eac3dec.c	(original)
> +++ eac3/eac3dec.c	Wed Sep 12 09:53:51 2007
> @@ -351,14 +351,14 @@ static int parse_bsi(GetBitContext *gbc,
>  
>      s->nfchans = ff_ac3_channels[s->acmod];
> -    s->ntchans = s->nfchans;
> -    s->lfe_channel = s->ntchans+1;
> +    s->num_channels = s->nfchans;
> +    s->lfe_channel = s->num_channels+1;
>      if(s->lfeon){
>          s->strtmant[s->lfe_channel] = 0;
>          s->endmant[s->lfe_channel] = 7;
>          s->nchgrps[s->lfe_channel] = 2;
>          s->chincpl[s->lfe_channel] = 0;
> -        s->ntchans++;
> +        s->num_channels++;

Note that this could be nicely aligned (same in other places).

> @@ -1051,7 +1051,7 @@ static int parse_audblk(GetBitContext *g
> -    for(ch=!s->cplinu[blk]; ch<=s->ntchans; ch++){
> +    for(ch=!s->cplinu[blk]; ch<=s->num_channels; ch++){
>          if(s->chexpstr[blk][ch]!=EXP_REUSE){

Note that "for (" and "if (" is preferred.

Diego



More information about the FFmpeg-soc mailing list