[FFmpeg-soc] [soc]: r1398 - dvbmuxer/mpegtsenc.c

[Baptiste Coudurier]

Hi

Michael Niedermayer wrote:
> Hi
> 
> On Fri, Oct 05, 2007 at 03:29:33PM +0200, bcoudurier wrote:
>> Author: bcoudurier
>> Date: Fri Oct  5 15:29:32 2007
>> New Revision: 1398
>>
>> Log:
>> use rc max rate only if it set, use bitrate if not, safer than (arbitrary?) big value for pcr computation
> 
> the mux rate IIRC limits the maximum bitrates which can feed the video/audio
> (whatever they where called) buffers thus this change means that video must
> now be true CBR with min_rate=max_rate
> (or in other words this is a step from maybe compliant to certainly not mpeg
> compliant and is not useable for ffmpeg svn)

Well considering mux_rate, in this ts muxer, is only used to compute
pcr/sdt/pat packets frequency and to calculate pcr, IMHO using average
bitrate would be better than using (1<<21)*8/s->nb_streams in terms of
errors.

I think the same applies to mpeg ps muxer, which uses max_rate to
compute scr.

> also note that microsofts WMP is totally broken and its of no relevance if it
> can play a stream or not, they only must be compliant to what is written in
> the mpeg spec

Oh yes, who cares about WMP ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312