[FFmpeg-soc] [soc]: r254 - matroska/matroskaenc.c

[David Conrad]

On Jun 14, 2007, at 3:50 PM, Michael Niedermayer wrote:

> Hi
>
> On Thu, Jun 14, 2007 at 03:19:46AM +0200, conrad wrote:
>> Author: conrad
>> Date: Thu Jun 14 03:19:46 2007
>> New Revision: 254
>>
>> Log:
>> Correctly write CodecPrivate element for Vorbis and Theora
>
> [...]
>
>> +                codecprivate = start_ebml_master(pb,  
>> MATROSKA_ID_CODECPRIVATE);
>> +                put_byte(pb, 2);                    // number  
>> packets - 1
>> +                for (j = 0; j < 2; j++) {
>> +                    for (k = 0; k < header_len[j] / 255; k++)
>> +                        put_byte(pb, 255);
>> +                    put_byte(pb, header_len[j]);
>
> this looks buggy
>
> header_len=255 would store
> 255, 255

You're right, it should be 255, 0 in that case. It should be correct  
now.