[FFmpeg-soc] [soc]: r208 - matroska/split-mkv-demuxer.diff

[David Conrad]

On Jun 4, 2007, at 6:19 PM, Aurelien Jacobs wrote:

> On Fri,  1 Jun 2007 06:43:00 +0200 (CEST)
> conrad <subversion at mplayerhq.hu> wrote:
>
>> Author: conrad
>> Date: Fri Jun  1 06:43:00 2007
>> New Revision: 208
>>
>> Log:
>> Preliminary patch to split some common code that will likely be  
>> used in the mkv muxer from the demuxer
>
> Ok, that's something needed.
> As I had some pending changes for the matroska demuxer, and that I  
> didn't
> wanted to break your patch, I first applied your patch to ffmpeg.
> I guess it can only ease your work, and you can now svn rm that  
> diff file.
> If you have more code to split later, this can be done directly in
> ffmpeg repository.
>
> BTW: It's nice to see you already seriously started working on your  
> SoC
> project. I will carefully follow and review your progression.
> Don't forget I'm available to reply any question you may have or to
> help you if you have a problem.

And then I disappear for two weeks, sorry about that. I now have the  
muxer working with some video under a minute long, I'll commit the  
changes shortly. Anyways some questions:

1. Currently, for EBML master elements, I reserve the maximum 8 bytes  
for the size in start_ebml_master(), which is obviously wasteful  
since it's used for each frame which doesn't need the full 8 bytes.  
I'm not sure how best to only use the needed number of bytes for  
writing the size. I was thinking maybe passing an estimate of large  
the master is going to be as a parameter to start_ebml_master(), but  
I'm not sure how accurate I could make all the estimates, especially  
for larger elements like clusters and segments.

2. Since Matroska only allows one timescale per segment, how should I  
choose this? Right now I always use 1/1000, which is what just about  
every mkv file that I've seen uses, but should I select something  
else based on the framerate of a track?

3. Currently, I only write SimpleBlocks instead of the more complex  
BlockGroup. The main disadvantage I see with this is that older  
parsers don't support it (lavf has only had support for 3 months,  
since r8180), so is it worth it to add an option to force Matroska v1  
files to be written? And if so, how should that be done?