[FFmpeg-soc] [soc]: r243 - dirac/dirac_parser.c

Luca Barbato lu_zero at gentoo.org
Sun Jun 10 16:58:58 CEST 2007


Some cosmetics comment follows,

marco wrote:
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */

You may add a doxy header with @file and a simple description of it (ok
there it isn't that meaningful, but for consistency...

> +
> +static int dirac_parse(AVCodecParserContext *s,
> +                           AVCodecContext *avctx,
> +                           const uint8_t **poutbuf, int *poutbuf_size,
> +                           const uint8_t *buf, int buf_size)

put AVCodecContext *avctx on the first line and align the other vars to
the (

> +
> +    if(s->flags & PARSER_FLAG_COMPLETE_FRAMES){
> +        next= buf_size;

next = buf_size;

> +    }else{
> +        next= find_frame_end(pc, buf, buf_size);

next = find_frame_end(pc, buf, buf_size);

Beside that seems fine.

lu

-- 

Luca Barbato

Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero



More information about the FFmpeg-soc mailing list