[FFmpeg-soc] [soc]: r209 - matroska/matroskaenc.c

[Michael Niedermayer]

Hi

On Sat, Jun 02, 2007 at 09:39:34PM -0400, David Conrad wrote:
[...]
> > [...]
> >> +// XXX: should we do any special checking for valid strings for  
> >> these 2 functions?
> >
> > i would say no, or put the checks in generic lavf code, duplicating  
> > string
> > validity checks in every muxer is silly ...
> 
> Looking at the Matroska spec again, I only see only one string  
> written as ASCII being user-specifiable in lavf right now, the ISO  
> 639-2 language code. The other user-specifiable strings would be  
> written as UTF-8. I don't think the language code is being checked  
> anywhere, but if it were, it probably should be against the official  
> table of codes. If I were to write string validity checks for user- 
> specified strings, where should they go in lavf?

av_write_header() / a function called by av_write_header() would be
the most obvious place

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20070603/76fc7aab/attachment.pgp>