[FFmpeg-soc] [soc]: r462 - dirac/dirac.c

Marco Gerards mgerards at xs4all.nl
Wed Jul 18 13:37:32 CEST 2007


Michael Niedermayer <michaelni at gmx.at> writes:

>> @@ -846,14 +845,14 @@ static int sign_predict(AVCodecContext *
>>              return 0;
>>          else {
>>              if (data[x + (y - 1) * s->padded_width] == 0) return 0;
>> -            return (data[x + (y - 1) * s->padded_width] < 0) ? -1 : 1;
>> +            return FFSIGN(data[x + (y - 1) * s->padded_width] < 0);
>>          }
>>      case subband_lh:
>>          if (h == 0)
>>              return 0;
>>          else {
>>              if (data[x + y * s->padded_width - 1] == 0) return 0;
>> -            return (data[x + y * s->padded_width - 1] < 0) ? -1 : 1;
>> +            return FFSIGN(data[x + y * s->padded_width - 1] < 0);
>>          }
>>      }
>
> the < 0 looks like a oversight ...

It is, nice catch! :-)

I just committed a fix.

Thanks,
Marco




More information about the FFmpeg-soc mailing list