[FFmpeg-soc] [soc]: r417 - in libavfilter: avfilter.c avfilter.h filter_test.c

[Michael Niedermayer]

Hi

On Sat, Jul 14, 2007 at 03:54:47PM -0400, Bobby Bingham wrote:
> On Sat, 14 Jul 2007 21:35:24 +0200
> Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > Hi
> > 
> > On Sat, Jul 14, 2007 at 09:33:28PM +0200, koorogi wrote:
> > > Author: koorogi
> > > Date: Sat Jul 14 21:33:28 2007
> > > New Revision: 417
> > > 
> > > Log:
> > > Allow giving filter instances names, in anticipation of the upcoming
> > > AVFilterGraph structure and related functions.
> > > 
> > > 
> > > Modified:
> > >    libavfilter/avfilter.c
> > >    libavfilter/avfilter.h
> > >    libavfilter/filter_test.c
> > > 
> > > Modified: libavfilter/avfilter.c
> > > ==============================================================================
> > > --- libavfilter/avfilter.c	(original)
> > > +++ libavfilter/avfilter.c	Sat Jul 14 21:33:28 2007
> > > @@ -288,13 +288,14 @@ static const char *filter_name(void *p)
> > >      return filter->filter->name;
> > >  }
> > >  
> > > -AVFilterContext *avfilter_create(AVFilter *filter)
> > > +AVFilterContext *avfilter_create(AVFilter *filter, char *inst_name)
> > >  {
> > >      AVFilterContext *ret = av_malloc(sizeof(AVFilterContext));
> > >  
> > >      ret->av_class = av_mallocz(sizeof(AVClass));
> > >      ret->av_class->item_name = filter_name;
> > >      ret->filter   = filter;
> > > +    ret->name     = inst_name ? strdup(inst_name) : NULL;
> > 
> > av_strdup
> > 
> 
> Ok.  will fix.  I didn't notice the existence of av_strdup because I
> looked in avutil/string.c and didn't see it there. I think it makes
> more sense to have it there with the other string functions. Should I
> send a patch to move it?

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20070714/bd6484b6/attachment.pgp>