[FFmpeg-soc] [soc]: r340 - qcelp/qcelpdec.c

Reynaldo Verdejo rverdejo at gmail.com
Sun Jul 8 15:48:19 CEST 2007


Hi Michael

On 7/8/07, Michael Niedermayer <michaelni at gmx.at> wrote:
>
>
> > +void qcelp_lspv2lspf(const uint8_t *lspv, float *lspf)
> > +{
> > +    lspf[0]=        qcelp_lspvq1[lspv[0]].x;
> > +    lspf[1]=lspf[0]+qcelp_lspvq1[lspv[0]].y;
> > +    lspf[2]=lspf[1]+qcelp_lspvq2[lspv[1]].x;
> > +    lspf[3]=lspf[2]+qcelp_lspvq2[lspv[1]].y;
> > +    lspf[4]=lspf[3]+qcelp_lspvq3[lspv[2]].x;
> > +    lspf[5]=lspf[4]+qcelp_lspvq3[lspv[2]].y;
> > +    lspf[6]=lspf[5]+qcelp_lspvq4[lspv[3]].x;
> > +    lspf[7]=lspf[6]+qcelp_lspvq4[lspv[3]].y;
> > +    lspf[8]=lspf[7]+qcelp_lspvq5[lspv[4]].x;
> > +    lspf[9]=lspf[8]+qcelp_lspvq5[lspv[4]].y;
> > +}
>
> this looks like it should be a for() loop


There are 5 tables there, not grouped but on isolated arrays, thats why I
didn't use a loop. Anyway, the whole table(s) structure might change in the
inmediate future, Ben wants me to review and rework it, I will add a FIXME
instead, just in case it doesn't.

   Reynaldo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20070708/0ff71307/attachment.htm>


More information about the FFmpeg-soc mailing list