[FFmpeg-soc] [soc]: r323 - in rv40: rv40.c rv40data.h rv40vlc2.h

[Michael Niedermayer]

Hi

On Fri, Jul 06, 2007 at 01:12:42PM +0300, Kostya wrote:
[...]
> > [...]
> > > +#define MODE2_PATTERNS_NUM 20
> > > +/**
> > > + * Intra types table
> > > + *
> > > + * These values are actually base 10 coded 3-tuples
> > > + * used for detecting standard block configurations
> > > + */
> > > +static const uint16_t rv40_aic_table_index[MODE2_PATTERNS_NUM] = {
> > > +   0, 100, 200,
> > > +  11, 111, 211, 511, 611,
> > > +  22, 122, 222, 722,
> > > + 272, 227,
> > > + 822, 282, 228,
> > > + 112, 116, 221
> > > +};
> > 
> > coding them base 8 or 16 seems like it would be a much better idea ...
> 
> It's base 10 coded so each digit in decimal representation has its own
> meaning. Also it is grouped that way to join similar groups. 

still why is it not octal or hex 0x227 looks fine too and split and merge
can be done with << & | instead of slow * / %

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20070706/a69ca81c/attachment.pgp>