[FFmpeg-soc] [soc]: r316 - in libavfilter: avfilter.c avfilter.h filter_test.c vf_crop.c vo_sdl.c vsrc_dummy.c

[Bobby Bingham]

On Thu, 5 Jul 2007 23:16:54 +0200
Michael Niedermayer <michaelni at gmx.at> wrote:

> Hi
> 
> On Thu, Jul 05, 2007 at 10:48:48PM +0200, koorogi wrote:
> > Author: koorogi
> > Date: Thu Jul  5 22:48:48 2007
> > New Revision: 316
> > 
> > Log:
> > Rework filter initialization sequence.  Now supports passing user
> > parameters, querying supported colorspaces, etc.
> [...]
> > @@ -91,6 +92,7 @@ int avfilter_link(AVFilterContext *src, 
> >                    AVFilterContext *dst, unsigned dstpad)
> >  {
> >      AVFilterLink *link;
> > +    int *fmts[2], i, j;
> >  
> 
> shouldnt this be enum PixelFormat ?

Maybe.  For the functions where there's a clear analog with audio, I'm
trying to keep the interface general enough that it could be reused for
audio filters in case somebody eventually wants to add support for that
in the libavfilter.  If you prefer that I focus it more on just video
for the moment, I can certainly change this to enum PixelFormat.

> 
> 
> [...]
> > +    src->filter->outputs[srcpad].config_props(link);
> > +    dst->filter->inputs[dstpad].config_props(link);
> 
> nitpick:
> src->filter->outputs[srcpad].config_props(link);
> dst->filter-> inputs[dstpad].config_props(link);

will change.

> 
> 
> [...]
> > +int *avfilter_make_format_list(int len, ...)
> > +{
> > +    int *ret, i;
> > +    va_list vl;
> > +
> > +    ret = av_malloc(sizeof(int) * (len + 1));
> > +    va_start(vl, len);
> > +    for(i = 0; i < len; i ++)
> > +        ret[i] = va_arg(vl, int);
> > +    va_end(vl);
> > +    ret[len] = -1;
> 
> should this be PIX_FMT_NONE instead of -1?

See above.

> 
> [...]


-- 
Bobby Bingham
Never trust atoms.  Or anything made of atoms.
このメールは再利用されたバイトでできている。