[FFmpeg-soc] [soc]: r313 - in qcelp: doc/NOTES qcelp.h qcelp_glue.diff qcelpdec.c

Michael Niedermayer michaelni at gmx.at
Thu Jul 5 22:27:47 CEST 2007


Hi

On Thu, Jul 05, 2007 at 10:18:38PM +0200, reynaldo wrote:
> Author: reynaldo
> Date: Thu Jul  5 22:18:38 2007
> New Revision: 313
> 
> Log:
> Should address most of your comments

it would have been better to split cosmetic from non cosmetic changes


[...]

> -            q->frame->type = RATE_FULL;
> -            q->frame->bits = qcelp_bits_per_type[RATE_FULL];
> -            order = QCELP_REFERENCE_FRAME + QCELP_FULLPKT_REFERENCE_POS;
> +            q->frame->rate = RATE_FULL;
> +            q->frame->bits = qcelp_bits_per_rate[RATE_FULL];
> +            order =
> +            (QCELPBitmap*)(QCELP_REFERENCE_FRAME + QCELP_FULLPKT_REFERENCE_POS);

useless cast?


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20070705/ed83d118/attachment.pgp>


More information about the FFmpeg-soc mailing list