[FFmpeg-soc] [soc]: r1601 - libavfilter/diffs/04_ffmpeg_filters.diff

Aurelien Jacobs aurel at gnuage.org
Wed Dec 19 23:50:55 CET 2007


Vitor wrote:

> Hi
> 
> Aurelien Jacobs wrote:
> > vitor wrote:
> 
> [...]
> 
> >>                   }
> >>               }
> >> ++#if ENABLE_AVFILTER
> >>  +        if(ist->picref)
> >>  +            avfilter_unref_pic(ist->picref);
> >> -+
> >> ++#endif
> > 
> > IMO, this would be nicer written this way:
> > 
> >         if (ENABLE_AVFILTER && ist->picref)
> >             avfilter_unref_pic(ist->picref);
> > 
> > Aurel
> 
> Would this be valid C99? Because ist has no member named picref if 
> ENABLE_AVFILTER is false...

Ah... Sorry. I didn't noticed this.
So indeed, #if is the right thing to do.

Aurel



More information about the FFmpeg-soc mailing list