[FFmpeg-soc] [soc]: r1549 - eac3/eac3dec.c

Benoit Fouet benoit.fouet at purplelabs.com
Tue Dec 11 09:04:22 CET 2007


jbr wrote:
> Author: jbr
> Date: Tue Dec 11 05:30:21 2007
> New Revision: 1549
>
> Log:
> fix noise in output by properly zeroing unused coefficients
>
> Modified:
>    eac3/eac3dec.c
>
> Modified: eac3/eac3dec.c
> ==============================================================================
> --- eac3/eac3dec.c	(original)
> +++ eac3/eac3dec.c	Tue Dec 11 05:30:21 2007
> @@ -326,7 +326,7 @@ static void get_eac3_transform_coeffs_ch
>      }
>  
>      memset(s->transform_coeffs[ch]+s->endmant[ch], 0,
> -            sizeof(s->transform_coeffs[0])-s->endmant[ch]);
> +           (AC3_MAX_COEFS - s->endmant[ch])*sizeof(float));
>  }
>   

i think the sizeof() should be kept (not changed to sizeof(float)), if
one day what you memset has its type changed, this is one bug less to fix :)

-- 
Ben
Purple Labs S.A.
www.purplelabs.com



More information about the FFmpeg-soc mailing list