[FFmpeg-soc] [soc]: r1103 - in qcelp: qcelpdata.h qcelpdec.c

Diego Biurrun diego at biurrun.de
Tue Aug 21 00:26:55 CEST 2007


On Mon, Aug 20, 2007 at 11:30:07PM +0200, reynaldo wrote:
> 
> Log:
> Fix spec omission at codebook vector computation formula
> 
> --- qcelp/qcelpdata.h	(original)
> +++ qcelp/qcelpdata.h	Mon Aug 20 23:30:06 2007
> @@ -36,6 +36,22 @@
>  
> +/**
> + * TIA/EIA/IS-733 Spec has an omission on the codebook index determination
> + * formula for RATE_FULL and RATE_HALF frames at section 2.4.8.1.1. It says
> + * you have to subtract the decoded index parameter to the given scaled
> + * codebook vector index 'n' to get the desired circular codebook index but
> + * It doesn't tell you have to clamp 'n' to [0-9] in order to get RI complaint

it, complIAnt

Note that complAInt is a valid, but very different English word.

> + * The reason for this mistake seems to be the fact they forget to tell you
> + * have to do this calculations per codebook subframe and adjust given equation

Either "this calculation" or "these calculations".

> + * If not were by the obvious 'counting till 10' detail,

I can only guess what you mean here: "If it were not for the obvious
'count until 10' detail"?

Diego



More information about the FFmpeg-soc mailing list