[FFmpeg-soc] [soc]: r747 - in eac3: ac3tab.c ac3tab.h eac3_parser.c

Diego Biurrun diego at biurrun.de
Mon Aug 13 19:48:31 CEST 2007


On Mon, Aug 13, 2007 at 07:44:35PM +0200, bwolowiec wrote:
> 
> Log:
> Spectral extension. Now turned off, because there are no samples for testing it.
> 
> --- eac3/eac3_parser.c	(original)
> +++ eac3/eac3_parser.c	Mon Aug 13 19:44:35 2007
> @@ -1503,3 +1512,118 @@ int ff_eac3_parse_auxdata(GetBitContext 
> +
> +void spectral_extension(EAC3Context *s){
> +#if 0

Please add a comment similar to the log message to the preprocessor
directive.  That way it's immediately clear why the function is disabled
without perusing Subversion history.

> --- eac3/ac3tab.h	(original)
> +++ eac3/ac3tab.h	Mon Aug 13 19:44:35 2007
> @@ -58,6 +58,7 @@ extern const int16_t (*ff_vq_hebap[8])[6
>  extern const uint8_t ff_eac3_frm_expstr[32][6];
>  extern const uint8_t ff_eac3_defcplbndstrc[18];
>  extern const uint8_t ff_eac3_defspxbndstrc[17];
> +extern const float ff_eac3_spxattentab[32][3];

nit: This could be aligned.

Diego



More information about the FFmpeg-soc mailing list