[FFmpeg-soc] [soc]: r719 - in qcelp: README doc/TODO qcelpdec.c

[Michael Niedermayer]

Hi

On Sun, Aug 12, 2007 at 10:45:02AM +0200, reynaldo wrote:
[...]
> +
> +                if(lag[i] == 140.5 || lag[i] == 141.5 || lag[i] == 142.5)

be carefull with == checks and floating point variables
this can fail in cases like
140.499999 != 140.5

(i guess its written in the spec like that but its silly, likely the mere use
of floats and doubles is silly but i dunno qcelp well enough to say for sure
if it could be done easily without floats and doubles)

PS: yes, if things can easily be done with fixed point variables they should
instead of using floats

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20070812/61f45893/attachment.pgp>