[FFmpeg-soc] [soc]: r658 - in matroska: matroskaenc.c mkv-muxer.diff

David Conrad umovimus at gmail.com
Sat Aug 11 21:10:20 CEST 2007


On Aug 10, 2007, at 4:03 AM, Diego Biurrun wrote:

> On Fri, Aug 10, 2007 at 01:37:14AM +0200, conrad wrote:
>
>>
>> Log:
>> Add mka muxer
>>
>> --- matroska/mkv-muxer.diff    (original)
>> +++ matroska/mkv-muxer.diff    Fri Aug 10 01:37:14 2007
>> -@@ -92,7 +92,7 @@ void av_register_all(void)
>> +@@ -92,7 +92,8 @@ void av_register_all(void)
>>  -    REGISTER_DEMUXER (MATROSKA, matroska);
>>  +    REGISTER_MUXDEMUX(MATROSKA, matroska);
>> ++    REGISTER_MUXER   (MATROSKA, matroska_audio);
>>
>
> Why isn't it (MATROSKA_AUDIO, matroska_audio)?

I thought that since the only code that different between the mka and  
mkv muxer was the AVOutputFormat definition (mime-type, extension,  
and lack of video/subtitle codecs) that they might as well use the  
same configure define. Changed for consistency.

>> -@@ -141,6 +141,7 @@ extern AVOutputFormat image_muxer;
>> +@@ -144,6 +144,8 @@ extern AVOutputFormat image_muxer;
>>   extern AVOutputFormat m4v_muxer;
>>  +extern AVOutputFormat matroska_muxer;
>> ++extern AVOutputFormat matroska_audio_muxer;
>>
>
> This is not alphabetical order.

Fixed.



More information about the FFmpeg-soc mailing list